Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add localization to example #404

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Add localization to example #404

merged 2 commits into from
Aug 15, 2024

Conversation

amantoux
Copy link
Member

Closes #402

@amantoux amantoux requested a review from Amir-P August 12, 2024 08:41
@amantoux
Copy link
Member Author

@Amir-P can you please review?

@codecov Codecov
Copy link

codecov bot commented Aug 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.91%. Comparing base (817b2e0) to head (ef9d929).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #404   +/-   ##
=======================================
  Coverage   87.91%   87.91%           
=======================================
  Files          62       62           
  Lines       10331    10331           
=======================================
  Hits         9083     9083           
  Misses       1248     1248

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Amir-P
Amir-P approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@Amir-P Amir-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@amantoux amantoux merged commit 096cd1c into master Aug 15, 2024
4 checks passed
@amantoux amantoux deleted the example_supports_localization_in_french branch August 15, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maelchiotti maelchiotti maelchiotti requested changes

@Amir-P Amir-P Amir-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add localization to example
3 participants
@amantoux @Amir-P @maelchiotti